update useRef documentation to use ref prop instead of forwardRef#7332
update useRef documentation to use ref prop instead of forwardRef#7332joshuaslate wants to merge 4 commits intoreactjs:mainfrom joshuaslate:ref-prop-instead-of-forward-ref
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @joshuaslate! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
there are a lot of unrelated whitespace changes
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
let's remove the optional chaining, use the crash to explain the problem, and remove the unnecessary ...props thing
|
sorry for the churn, we ended up merging #7364, seems like maybe this overlaps fully and can be closed? |
3 participants
I noticed a couple of spots in the documentation that were suggesting using
forwardRef. I updated them to use therefprop instead.