Disallow /index.html in sandboxes to fix forks on CodeSandbox#7430
Merged
eps1lon merged 1 commit intoreactjs:mainfrom Jan 14, 2025
Merged
Disallow /index.html in sandboxes to fix forks on CodeSandbox#7430eps1lon merged 1 commit intoreactjs:mainfrom
/index.html in sandboxes to fix forks on CodeSandbox#7430eps1lon merged 1 commit intoreactjs:mainfrom
Conversation
Forks on CodeSandbox will ignore `/index.html` and create their own `public/index.html` which leads to broken sandboxes in CodeSandbox. We now throw if `/index.html` is used and only use `public/index.html` which works both in Sandpack and CodeSandbox. This also means we're consistent. Some sandboxes were already using the functioning `public/index.html`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
110.38 KB (🟡 +2 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
rickhanlonii
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forks on CodeSandbox will ignore
/index.htmland create their ownpublic/index.htmlwhich leads to broken sandboxes in CodeSandbox.Compare a forked sandbox from
mainvs forked sandbox from this branchWe now throw if
/index.htmlis used and only usepublic/index.htmlthroughout the codebase which works both in Sandpack and CodeSandbox.This also means we're consistent. Some sandboxes were already using the functioning
public/index.htmle.g. https://react.dev/reference/react-dom/client/hydrateRoot#hydrating-server-rendered-html.