Bring docs for cloneElement in line with @react/types types#7459
Bring docs for cloneElement in line with @react/types types#7459jimhigson wants to merge 1 commit intoreactjs:mainfrom
@react/types types#7459Conversation
|
Hi @jimhigson! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
2 participants
The docs for cloneElement give examples that are not legal as per the types in
@types/react.Of the the overlaods here give the type for the props parameter as some variant of
props?: P- in typescript?:will allow undefined but not null. However, the docs say to usenull.This means that currently, for someone creating the typical react app with common scaffolds that include typescript, using the examples from the docs will give type errors.