Open
Conversation
## Fix misleading explanation about props and event handlers in rendering ### Description This PR updates the explanation of how React handles props, event handlers, and local variables during rendering. The original text stated: > *"Its props, event handlers, and local variables were all calculated **using its state at the time of the render.**"* However, this is misleading because: 1. **Props** are **not** calculated from a component's state. They are passed from the **parent component** and only reflect the state of the **parent at the time of its last render**. 2. **Event handlers** do not get "calculated" per render but rather **capture the state from the moment they were created**. Unless wrapped in [`useCallback`](https://react.dev/reference/react/useCallback), they will be re-created on every render but will still close over the state at the time of their creation. ### **Updated text:** > Local variables and event handlers capture the state **from the moment the component rendered**. Props are received from the parent and reflect the parent's state **at the time of the parent’s last render**. ### **Why this change?** The new phrasing clarifies that: - **Props come from the parent and are not derived from state.** - **Event handlers reference the state of the render in which they were created.** - **Local variables are tied to the specific render snapshot.** This should prevent confusion, especially for developers who might misinterpret it as meaning that props are calculated from state.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix misleading explanation about props and event handlers in rendering
Description
This PR updates the explanation of how React handles props, event handlers, and local variables during rendering. The original text stated:
However, this is misleading because:
useCallback, they will be re-created on every render but will still close over the state at the time of their creation.Updated text:
Why this change?
The new phrasing clarifies that:
This should prevent confusion, especially for developers who might misinterpret it as meaning that props are calculated from state.