fix(reference): declare subscribe before passing it to the hook (issue #7707)#7711
Merged
rickhanlonii merged 1 commit intoreactjs:mainfrom Apr 2, 2025
hugmouse:fix/typo-in-useSyncExternalStorage
Merged
fix(reference): declare subscribe before passing it to the hook (issue #7707)#7711rickhanlonii merged 1 commit intoreactjs:mainfrom hugmouse:fix/typo-in-useSyncExternalStorage
subscribe before passing it to the hook (issue #7707)#7711rickhanlonii merged 1 commit intoreactjs:mainfrom
hugmouse:fix/typo-in-useSyncExternalStorage
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the typo in the docs, related issue: #7707
Context from the issue
The following code will throw
Uncaught TypeError: subscribe is not a function.react.dev/src/content/reference/react/useSyncExternalStore.md
Lines 438 to 447 in b5f5134
Documentation page: https://react.dev/reference/react/useSyncExternalStore#my-subscribe-function-gets-called-after-every-re-render
Fix
Just declaring
subscribebefore passing it to the hook.Screenshot
In case you don't want to check out the auto-generated preview :)