Update your-first-component.md: Show example rendered output as <img> instead of <img />#7757
Update your-first-component.md: Show example rendered output as <img> instead of <img />#7757chipit24 wants to merge 1 commit intoreactjs:mainfrom
your-first-component.md: Show example rendered output as <img> instead of <img />#7757Conversation
In HTML, `img` elements are void elements that don't have an end tag and are not self-closing. This is what you would see if you opened the DOM in any modern browser, so I think the docs should accurately reflect this.
|
Hi @chipit24! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
In HTML,
imgelements are void elements that don't have an end tag and are not self-closing. This is what you would see if you opened the DOM in any modern browser; this PR updates the Using a component → What the browser sees section of the docs to more accurately reflect this.Also, in other parts of the docs, e.g. at Writing Markup with JSX → Converting HTML to JSX, the
imgtag is correctly written:And an explanation is even given later on, though it's inaccurate since HTML technically does not have close-closing tags (I'll get another PR up to update that we well):
Aside (interesting read 😁): The case against self-closing tags in HTML by Jake Archibald (06 July 2023)