fix: update crossOrigin description to clarify requirement when using as="fetch"#7783
Closed
vishal-rathod-07 wants to merge 3 commits intoreactjs:mainfrom
Closed
fix: update crossOrigin description to clarify requirement when using as="fetch"#7783vishal-rathod-07 wants to merge 3 commits intoreactjs:mainfrom
vishal-rathod-07 wants to merge 3 commits intoreactjs:mainfrom
Conversation
sophiebits
requested changes
May 16, 2025
Member
sophiebits
left a comment
There was a problem hiding this comment.
as="fetch" isn't valid for these so this doesn't make sense. If you want to preload a URL that you will fetch then I believe call preload with as="fetch".
Member
|
For preloadModule perhaps we could allow setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update crossOrigin prop description to explicitly state that it's required when using
as="fetch".The documentation lacked clarity in several places about the mandatory nature of crossOrigin when the as prop is set to "fetch". This change:
Also closes #6617