Merged
Conversation
sophiebits
approved these changes
Apr 29, 2025
Member
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
if the form’s on top do you wanna prepend instead of append?
Member
Author
|
@sophiebits good call, fixed |
sebmarkbage
reviewed
Apr 30, 2025
| }) | ||
| } | ||
| return <Thread messages={messages} sendMessage={sendMessage} />; | ||
| return <Thread messages={messages} sendMessageAction={sendMessageAction} />; |
Contributor
There was a problem hiding this comment.
This shouldn't really use the Action suffix convention if you do it this way because that implies that Thread wraps it in startTransition for you (which it could if you want to). That's what an Action is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example was busted because the setState after await wasn't inside
startTransition. Also converted it to use the action prop naming pattern, and put the form on top so it doesn't move when you submit.