Fixed broken placeholder links on manipulating dom with refs page#7849
Fixed broken placeholder links on manipulating dom with refs page#7849daniel-norris wants to merge 1 commit intoreactjs:mainfrom
Conversation
|
Hi @daniel-norris! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I think we should just host them ourselves and do a pass to remove any external image links from the docs. Would you mind taking a look at that? I'd also prefer to keep cats personally. But if you do the above, I can take dogs. |
|
One argument to keep cats is to avoid churning the translations. |
Sure ok, I can have a look at some options. Anything in particular you had in mind here? What about simply putting them in https://github.com/reactjs/react.dev/tree/main/public/images/docs/illustrations or similar?
That's fair enough. |
Hi, was looking at the page below and noticed a couple things...
placecats.comis no longer working and I can't find the API documentation anymoreSolution:
🐕🦺