fix: prevent partial reset when canceling reset confirmation.#7877
fix: prevent partial reset when canceling reset confirmation.#7877vickrant-dev wants to merge 3 commits intoreactjs:mainfrom
Conversation
|
Hi @vickrant-dev! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
110.45 KB (🟡 +2 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
|
Hi @vickrant-dev! |
|
Let's go with this instead: #7954 |
"[Bug]: "Reset state" on the playgrounds UX is confusing" was open in github issues and the user addressed the issue as the following: "The only way I found is clicking on "Reset", which triggers a popup saying "Reset all your edits too?" and then pressing "Cancel". This will successfully reset the state but not the code."
I looked into the issue and it was a minor bug where the refresh() is called even if the confirm is not true which is clicking on cancel.
`const handleReset = () => {
/**
* resetAllFiles must come first, otherwise
* the previous content will appear for a second
* when the iframe loads.
*
* Plus, it should only prompt if there's any file changes
*/
if (sandpack.editorState === 'dirty') {
const confirmed = confirm('Reset all your edits too?');
if (!confirmed) return;
sandpack.resetAllFiles();
}
};`
Now, it's all changed and the bug is fixed. Thank you : )