Fix: Add missing Chat.js and complete ContactList.js dispatch logic i…#7902
Fix: Add missing Chat.js and complete ContactList.js dispatch logic i…#7902vaibhavibaware wants to merge 1 commit intoreactjs:mainfrom vaibhavibaware:fix/missing-components-messenger
Conversation
…n useReducer Messenger example
|
Hi @vaibhavibaware! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
There's nothing to be fixed here. The code you're editing is a challenge: https://react.dev/learn/extracting-state-logic-into-a-reducer#dispatch-actions-from-event-handlers The challenge is intended to be completed by the reader, so the TODOs are for the reader. And as your PR shows, editing the provided files is enough to complete the challenge. Your PR also does not "add |
This PR addresses two key issues in the Messenger example on the useReducer tutorial page:
Chat.jscomponent file, which is referenced inMessenger.js.ContactList.jsby handling thechanged_selectionaction correctly.fixes #7898