Fix: box-shadow animation on community photos transition#7905
Fix: box-shadow animation on community photos transition#7905gaearon merged 1 commit intoreactjs:mainfrom
Conversation
|
Hi @ChezFre! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
110.49 KB (🟡 +43 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/404 |
127.94 KB (🟡 +30 B) |
238.42 KB |
/500 |
127.95 KB (🟡 +30 B) |
238.43 KB |
/[[...markdownPath]] |
130.03 KB (🟡 +30 B) |
240.52 KB |
/errors |
128.19 KB (🟡 +30 B) |
238.67 KB |
/errors/[errorCode] |
128.17 KB (🟡 +30 B) |
238.65 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
e47751c to
8797991
Compare
|
thanks! |
The change from #7904 broke the fade transition on the box-shadow.
The original code added a box-shadow on hover, triggering a repaint from the browser. With these changes the box-shadow is always there with an opacity of 0 and fades in on hover.
Because the hidden overflow I had to add another wrapping element to prevent the pseudo element's box-shadow from being cut off.
Also fixes another issue where
overflow-x: hiddenwas combined withoverflow-y: visible, which doesn't work causing thebox-shadowto be cut off in Firefox.