Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
rickhanlonii
left a comment
rickhanlonii
left a comment
There was a problem hiding this comment.
LGTM just a note on the key
| for (let i = 0; i < 10; i++) { | ||
| catList.push("https://loremflickr.com/320/240/cat?lock=" + i); | ||
| if (i < 5) { | ||
| catList.push("https://placecats.com/neo/320/240"); |
There was a problem hiding this comment.
We probably shouldn't break the key in the example. Instead, this can push an object like {id: 1, src: 'https://...'}, or you could add an index param to the URL like in the previous version (like https://placecats.com/neo/320/240?id=1).
There was a problem hiding this comment.
Looks like we do both options in other examples
There was a problem hiding this comment.
yeah I noticed we were implicitly relying on the index previously so I thought to just keep it instead of fixing it. But you're right, let me fix that too
There was a problem hiding this comment.
fixed to use an object with an id!
The previous examples used a service called loremflickr.com to link to placeholder images. Since that service is now down, I updated them to reference placecats.com instead, which we already use in other examples as well. placecats doesn't have the same random cat feature so I roughly approximated it in the example code. Closes #7966
2 participants
The previous examples used a service called loremflickr.com to link to placeholder images. Since that service is now down, I updated them to reference placecats.com instead, which we already use in other examples as well. placecats doesn't have the same random cat feature so I roughly approximated it in the example code.
Closes #7966