docs: explain stale state in request counter example (fixes #8230)#8243
docs: explain stale state in request counter example (fixes #8230)#82432024si96556-Kishori wants to merge 2 commits intoreactjs:mainfrom
Conversation
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
kanikaa88
left a comment
There was a problem hiding this comment.
Thanks for the PR — a few small fixes please to avoid rendering/Sandpack breakage:
Please revert wrapping MDX components in backticks with {=html}. Examples: , , , , , , , . They should remain real MDX components.
Fix the mangled code fences (e.g. processQueue): keep the fence metadata on its own line and the code underneath (don’t put the fence and code on the same line).
Remove the stray backslash before the heading (change ### What happens... to ### What happens...).
Don’t wrap and similar components inside code fences — render them as components or use the repo’s admonition pattern.
Prefer pipe-style Markdown tables over preformatted text, and run the repo formatter (prettier/markdownlint) to normalize line-wrapping and list indentation.
After making these changes, please run the local/CI site preview to verify Sandpack examples and MDX components render correctly.
Thanks — happy to re-review once those are addressed.
|
Thanks for the detailed feedback! I’ve fixed the MDX component rendering, corrected the Sandpack code fences, removed the stray backslash in the heading, converted the tables to pipe-style Markdown, and verified the page renders correctly. Could you please take another look when convenient? Thanks again! |
No description provided.