Skip to content

Fix Version model ordering from descending to ascending #12636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −9
Draft

Fix Version model ordering from descending to ascending #12636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b90052
Initial plan
Copilot Dec 4, 2025
63b69de
Initial exploration - identified Version model ordering bug
Copilot Dec 4, 2025
33e4a37
Fix Version model ordering from descending to ascending and update tests
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions readthedocs/api/v3/tests/test_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def test_projects_versions_list_anonymous_user(self):
self.assertEqual(response.status_code, 200)
json_data = response.json()
self.assertEqual(len(json_data["results"]), 2)
self.assertEqual(json_data["results"][0]["slug"], "v1.0")
self.assertEqual(json_data["results"][1]["slug"], "latest")
self.assertEqual(json_data["results"][0]["slug"], "latest")
self.assertEqual(json_data["results"][1]["slug"], "v1.0")

# Versions are private
self.project.versions.update(privacy_level=PRIVATE)
Expand All @@ -54,16 +54,16 @@ def test_projects_versions_list(self):
self.assertEqual(response.status_code, 200)
response = response.json()
self.assertEqual(len(response["results"]), 2)
self.assertEqual(response["results"][0]["slug"], "v1.0")
self.assertEqual(response["results"][1]["slug"], "latest")
self.assertEqual(response["results"][0]["slug"], "latest")
self.assertEqual(response["results"][1]["slug"], "v1.0")

# Versions are private
Project.objects.filter(slug=self.project.slug).update(privacy_level=PRIVATE)
response = self.client.get(url)
response = response.json()
self.assertEqual(len(response["results"]), 2)
self.assertEqual(response["results"][0]["slug"], "v1.0")
self.assertEqual(response["results"][1]["slug"], "latest")
self.assertEqual(response["results"][0]["slug"], "latest")
self.assertEqual(response["results"][1]["slug"], "v1.0")

def test_projects_versions_list_other_user(self):
url = reverse(
Expand All @@ -80,8 +80,8 @@ def test_projects_versions_list_other_user(self):
self.assertEqual(response.status_code, 200)
json_data = response.json()
self.assertEqual(len(json_data["results"]), 2)
self.assertEqual(json_data["results"][0]["slug"], "v1.0")
self.assertEqual(json_data["results"][1]["slug"], "latest")
self.assertEqual(json_data["results"][0]["slug"], "latest")
self.assertEqual(json_data["results"][1]["slug"], "v1.0")

# Versions are private
self.project.versions.update(privacy_level=PRIVATE)
Expand Down
17 changes: 17 additions & 0 deletions readthedocs/builds/migrations/0066_alter_version_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Generated by Django 5.2.8 on 2025-12-04 21:26

from django.db import migrations


class Migration(migrations.Migration):

dependencies = [
('builds', '0065_task_executed_at'),
]

operations = [
migrations.AlterModelOptions(
name='version',
options={'ordering': ['verbose_name']},
),
]
2 changes: 1 addition & 1 deletion readthedocs/builds/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ class Version(TimeStampedModel):

class Meta:
unique_together = [("project", "slug")]
ordering = ["-verbose_name"]
ordering = ["verbose_name"]

def __str__(self):
return self.verbose_name
Expand Down