Fix indentation_width false positives for multi-line conditions#6505
Open
tanaev wants to merge 1 commit intorealm:mainfrom
Open
Fix indentation_width false positives for multi-line conditions#6505tanaev wants to merge 1 commit intorealm:mainfrom
indentation_width false positives for multi-line conditions#6505tanaev wants to merge 1 commit intorealm:mainfrom
Conversation
Generated by 🚫 Danger |
Skip continuation lines of multi-line `guard`/`if`/`while` condition lists that are aligned to the keyword rather than following the `indentation_width` grid. Add `include_multiline_conditions` option (default: `false`) to control this behavior. Fixes realm#4961
tanaev
force-pushed
the
fix/indentation-width-multiline-conditions
branch
from
af2d13b to
f158dbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
indentation_widthrule whenguard/if/whileconditions span multiple lines and are aligned to the keyword (e.g.,guard= 6 spaces), which is not a multiple ofindentation_widthMultilineConditionLineVisitor) that collects continuation line numbers and skips them during indentation checksinclude_multiline_conditionsconfiguration option (default:false) to control this behaviorFixes #4961
Test plan
testIncludeMultilineConditions()with cases forguard,if,while, nested conditions, andinclude_multiline_conditions: truenonTriggeringExamplesto rule description for multi-lineguardandifIndentationWidthRuleTestspass (14 + 1 new = 15 tests, 0 failures)