Add support for unknown types in DowngradeNamedArgumentRector#289
Merged
TomasVotruba merged 2 commits intomainfrom Jun 24, 2025
Merged
Add support for unknown types in DowngradeNamedArgumentRector#289TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-downgrade-container
branch
from
c74b5a3 to
07378ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the named args is used on a variable without any type, like in latest illuminate/contaienr 12.18.x
See illuminate/container@ff9dde2
In that case, we cannot leak this named variable further. All we can do is to take a guess, that value is used on the right location and remove it 👍