Skip to content

Revert "[DowngradePhp80] Register Override and SensitiveParameter to skipped attributes on DowngradeAttributeToAnnotationRector"#319

Merged
samsonasik merged 1 commit intomainfrom
revert-318-override-sensitive
Sep 8, 2025
Merged

Revert "[DowngradePhp80] Register Override and SensitiveParameter to skipped attributes on DowngradeAttributeToAnnotationRector"#319
samsonasik merged 1 commit intomainfrom
revert-318-override-sensitive

Conversation

@samsonasik
Copy link
Member

Reverts #318

@kkmuffme I Temporary revert to avoid error on downgrade:

Parse error: rector-prefixed-downgraded/vendor/illuminate/contracts/Hashing/Hasher.php:30
    28|      * @return bool
    29|      */
  > 30|     public function check(#[\SensitiveParameter] $value, $hashedValue, array $options = []);
    31|     /**
    32|      * Check if the given hash has been hashed using the given options.
Unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE)

see https://github.com/rectorphp/rector-src/actions/runs/17532914306/job/49817300076#step:14:70

@samsonasik samsonasik merged commit f29689b into main Sep 8, 2025
6 checks passed
@samsonasik samsonasik deleted the revert-318-override-sensitive branch September 8, 2025 07:21
samsonasik added a commit that referenced this pull request Sep 8, 2025
samsonasik added a commit that referenced this pull request Sep 8, 2025
* Revert "Revert "[DowngradePhp80] Register Override and SensitiveParameter to skipped …" (#319)"

This reverts commit f29689b.

* handle param new line before

* space

* namespace

* [ci-review] Rector Rectify

* space

---------

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments