DowngradeMbStrContainsRector

[arshidkv12]

No description provided.

[samsonasik]

This needs map opposite fixtures on rector-src on PR:

• MbStrContainsRector rector-src#7199

so we have similar functionality

[samsonasik]

This needs map opposite fixtures on rector-src on PR:

• rectorphp/rector-src#7199

so we have similar functionality

[arshidkv12]

$isMatch = str_contains(mb_substr('abc', $offset), 'a');

Convert to

 $isMatch = mb_strpos('abc', 'a', $offset) !== false;

https://github.com/rectorphp/rector-src/blob/main/rules-tests/Php80/Rector/NotIdentical/MbStrContainsRector/Fixture/offset_variable_zero_strpos.php.inc

Am I right?

[samsonasik]

Yes, ensure the value is match with upgrade code, the similar logic/service can be used.

[samsonasik]

I am thinking if the mb_strpos() only when needle is exact string and has multibyte, the original str_contains() to strpos() already converted on DowngradeStrContainsRector, so should be a logic to verify that the needle has multibye, eg:

strlen($needle) !== mb_strlen($needle)

this, however, I prefer to not be part of downgrade php 8.0 set, as dealing with multibyte can be "there on purpose", user that needs exact change str_contains -> mb_strpos needs to enable manually as use and know the risk.

[samsonasik]

Only when needle has multibyte value as well:

Suggested change

	return str_contains('abc', 'a');
	return str_contains('😊abc', '😊a');

[samsonasik]

Only when needle has multibyte value as well:

Suggested change

	return mb_strpos('abc', 'a') !== false;
	return mb_strpos('😊abc', '😊a') !== false;

[arshidkv12]

Ok

[samsonasik]

these fixtures are invalid, as no multibyte in needle, only downgrade to mb_strpos when needle has multibyte char

$isMatch = !str_contains('😊abc', 😊'a');

[samsonasik]

unregister this, there is no "mb_str_contains", only str_contains, that means that utilize strpos can be on purpose.

let user manually use if needed, dealing with user that may don't have mbstring extension or use strpos on purpose :)

user that use mb_ functions know why they are using the mb_ functions :)

[samsonasik]

early skip first class callable here:

if ($funcCall->isFirstClassCallable()) {
    return null;
}

[arshidkv12]

if (!$funcCall->isFirstClassCallable()) {
  return null;
}

Correct ?

[samsonasik]

no, should be below if (! $funcCall instanceof FuncCall) {:

        if (! $funcCall instanceof FuncCall) {
            return null;
        }

        if ($funcCall->isFirstClassCallable()) {
            return null;
        }

[samsonasik]

Add test fixture to skip no multibyte needle:

$isMatch = str_contains('abc', 'a');

[arshidkv12]

Added the string without multibyte needle.

[samsonasik]

skip first class callable haystack as well.

[samsonasik]

I prefer to rename to something like: DowngradeStrContainsWithMultibyteNeedleRector since there is no mb_str_contains, make clearer it actually use when needle has multibyte.

[arshidkv12]

Ok

[samsonasik]

After some checks, this rule is not needed, strpos is fine, since it doesn't verify position, only check non-falsy result, so strpos was fine as is, even needle contains multibyte, see

https://3v4l.org/cc4Di

I am closing this as that reasoning. Thank you for understanding.