Improve downgrade array spread stability#341
Merged
TomasVotruba merged 2 commits intomainfrom Oct 22, 2025
Merged
Conversation
…ost the same job, ref rectorphp/rector#9448
09da4fc to
5d44079
Compare
5d44079 to
f79dfe3
Compare
Member
|
While this fix the issue, the possible bug is the updated for multiple data, if ($intersectionType instanceof AccessoryArrayListType) {
return new ArrayType(new MixedType(), new MixedType());
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we're unable to resolve keys propperly, as relying on docblocks. This can lead to bugs as rectorphp/rector#9448
To safeguard this, Rector will always downgrade array spread to array_merge() if going down to PHP 8.1 or 7.4.