Revert rule removal of MatchAssertSameExpectedTypeRector

[samsonasik]

I will add test for invalid test after combined with AssertEqualsToSameRector

[samsonasik]

@TomasVotruba test added a59c746

Here the summary:

• Run:

vendor/bin/phpunit tests/Issues/AssertEqualsSame

• when apply scalar 123 to string type, the 123 become "123" via MatchAssertSameExpectedTypeRector
• then compare string vs string, it applied via AssertEqualsToSameRector, make "123" vs "0000000000000000000123", which invalid.

-'123'
+'0000000000000000000123'

This can be excluded only assertSame, but using assertSame means it already strict type on the very beginning, comparing this already error on very firs execution:

    public function test()
    {
        $this->assertSame('123', $this->getOrderId());
    }
    private function getOrderId(): int
    {
        return 123;
    }

There was 1 failure:

1) ArrayLookup\Tests\CollectorTest::test
Failed asserting that 123 is identical to '123'.

so, my propose was just remove the rule, because it doesn't make improvement.

[TomasVotruba]

Thanks 👌 I'll look into failing job today.

Next time ideally split revert + fixture, so we have passing CI and isolated test case.