Skip to content

[Php81] Skip non private modifier on ReadOnlyPropertyRector#1367

Merged
TomasVotruba merged 3 commits intomainfrom
skip-non-private-visibility-readonly
Dec 2, 2021
Merged

[Php81] Skip non private modifier on ReadOnlyPropertyRector#1367
TomasVotruba merged 3 commits intomainfrom
skip-non-private-visibility-readonly

Conversation

@samsonasik
Copy link
Member

Avoid error on public modifier like :

1) Rector\Tests\BetterPhpDocParser\PhpDocInlineHtml\TestInlineHtmlTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Error: Cannot modify readonly property Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace::$stmts

on #1364 (comment)

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 922e91d into main Dec 2, 2021
@TomasVotruba TomasVotruba deleted the skip-non-private-visibility-readonly branch December 2, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants