[Rectify] [Php81] Enable Rectify for finalize public class constant only#1380
Merged
TomasVotruba merged 6 commits intomainfrom Dec 4, 2021
Merged
[Rectify] [Php81] Enable Rectify for finalize public class constant only#1380TomasVotruba merged 6 commits intomainfrom
TomasVotruba merged 6 commits intomainfrom
Conversation
samsonasik
force-pushed
the
enable-finalize-public-class-constant
branch
from
ce06457 to
7d42b56
Compare
Member
Author
|
I temporary skip ArraySpreadInsteadOfArrayMergeRector::class as it make change for string key array unpack on php 8.1 which unrelated with this PR. |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
samsonasik
force-pushed
the
enable-finalize-public-class-constant
branch
from
d3cb3f6 to
1bb4d50
Compare
Member
Author
|
rebased. |
samsonasik
force-pushed
the
enable-finalize-public-class-constant
branch
from
d65f3ce to
a40013f
Compare
Member
Author
|
rebased. |
Member
|
Thank you, needs to rebase but feel free to merge 👍 |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split of #1364 by enable FinalizePublicClassConstantRector only.