Temporary pin symfony/service-contracts to 3.5.1#6930
Merged
samsonasik merged 2 commits intomainfrom May 25, 2025
Merged
Conversation
Member
Author
|
@TomasVotruba I will look into it, while temporary pin to 3.5.1 for now. |
Member
Author
|
I created real patch on downgrade part to support property promotion on trait: |
samsonasik
added a commit
that referenced
this pull request
May 26, 2025
This reverts commit 65b8b6b.
Member
Author
|
Reverting to test the downgrade patch: |
samsonasik
added a commit
that referenced
this pull request
May 26, 2025
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest 3.6.0 https://github.com/symfony/service-contracts/releases/tag/v3.6.0 seems cause downgrade error:
https://github.com/rectorphp/rector-src/actions/runs/15243096830/job/42865604088#step:14:72