Skip to content

[Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector#7109

Merged
samsonasik merged 3 commits intomainfrom
skip-diff-type-hooks
Aug 5, 2025
Merged

[Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector#7109
samsonasik merged 3 commits intomainfrom
skip-diff-type-hooks

Conversation

@samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @manticorp

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 34b45d4 into main Aug 5, 2025
47 checks passed
@samsonasik samsonasik deleted the skip-diff-type-hooks branch August 5, 2025 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClassPropertyAssignToConstructorPromotionRector should not promote unless type signatures match exactly in case of property hooks

1 participant