[Php84] Allow on return on ForeachToArrayAnyRector

[Orest-Divintari]

There is already a rule to convert foreach that contains a break statement with array_any. This pr is to add support to the existing rule to convert foreach with early return to array_any

[samsonasik]

On return need to be supported on downgrade rule first, which currently only on Expression

https://github.com/rectorphp/rector-downgrade-php/blob/3ca042a0b6cc60d3ce8e516cd45f82677e1fd843/rules/DowngradePhp84/Rector/Expression/DowngradeArrayAnyRector.php#L31

The ExprInTopStmtMatcher may need to be used for that for allow more usecases, see comment

• [DowngradePhp84] Add DowngradeArrayAllRector  rector-downgrade-php#290 (comment)

[samsonasik]

Actually, you may can improve existing rule

https://github.com/rectorphp/rector-src/blob/main/rules/Php84/Rector/Foreach_/ForeachToArrayAnyRector.php

[Orest-Divintari]

Actually, you may can improve existing rule

https://github.com/rectorphp/rector-src/blob/main/rules/Php84/Rector/Foreach_/ForeachToArrayAnyRector.php

i can do that sure, i wanted to check with you what is your preference
i started with a separate rule to not mix up anything yet

[samsonasik]

Would be better to improve downgrade rule first, as we most got issue after downgraded a target code

[Orest-Divintari]

i haven't managed to set it up locally properly and i can't run tests

for some reason when i do composer update it gets stuck at this stage

- Applying patches for illuminate/container https://raw.githubusercontent.com/rectorphp/vendor-patches/main/patches/illuminate-container-container-php.patch (0)

any idea what might be the issue ? @samsonasik

[samsonasik]

You may need to install gpatch, see troubleshooting note

https://github.com/symplify/vendor-patches/?tab=readme-ov-file#troubleshooting

[samsonasik]

FYI, here the downgrade rules update to allow return on array_*():

• [DowngradePhp84] Apply on return on DowngradeArrayAllRector  rector-downgrade-php#299
• [DowngradePhp84] Apply on return on DowngradeArrayAnyRector  rector-downgrade-php#300
• [DowngradePhp84] Apply on return on DowngradeArrayFindKeyRector rector-downgrade-php#301
• [DowngradePhp84] Apply on return on DowngradeArrayFindRector rector-downgrade-php#302

[Orest-Divintari]

i'll do also the downgrade rule

[samsonasik]

Downgrade rule already covered for return :)

• [DowngradePhp84] Apply on return on DowngradeArrayAnyRector  rector-downgrade-php#300

[Orest-Divintari]

does it cover also this code ?

 foreach ($animals as $animal) {
            if (str_starts_with($animal, 'c')) {
                return true;
            }
        }
        return false;

[samsonasik]

Downgrade is cover direct return function, change this:

return array_any($animals, fn($animal) => str_starts_with($animal, 'c'));

into:

$found = false;
foreach ($animals as $animal) {
    if (str_starts_with($animal, 'c')) {
        $found = true;
         break;
    }
}
return $found;

see fixture https://github.com/rectorphp/rector-downgrade-php/pull/300/files#diff-29bc31c0c16a251c20583c193cd7e88ca450703044d2c33ea28727a38d3cdc30

equivalent code needs exists when upgraded code downgraded, on rector usecase, rector downgraded to php 7.4, that's downgrade rule usage needs after new upgrade feture added, other lib/project that downgrade code after upgraded via rector needs that as well.

[samsonasik]

Okay, let's give it a try, thank you @Orest-Divintari

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.