Conversation
mttsch
commented
Aug 8, 2025
| declare(strict_types=1); | ||
|
|
||
| namespace Rector\Tests\Issues\IssueDoubleNestedAnnotatoinDocBlock; | ||
| namespace Rector\Tests\Issues\IssueDoubleNestedAnnotationDocBlock; |
Contributor
Author
There was a problem hiding this comment.
I doubt that changing the class name and namespace of a test class is considered a BC break?
samsonasik
reviewed
Aug 8, 2025
| */ | ||
| private function resolveName(string $prefix, string $tag, UseItem $useItem): string | ||
| { | ||
| // useuse can be renamed on the fly, so just in case, use the original one |
Member
There was a problem hiding this comment.
Just change useuse to UseItem
samsonasik
reviewed
Aug 8, 2025
| private function isUseMatchingName(string $tag, UseItem $useItem): bool | ||
| { | ||
| // useuse can be renamed on the fly, so just in case, use the original one | ||
| // use can be renamed on the fly, so just in case, use the original one |
Contributor
Author
There was a problem hiding this comment.
samsonasik
approved these changes
Aug 8, 2025
Member
|
Thank you @mttsch |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.