Skip to content

fix: allow more nodes to be passed to AttributeGroupNewLiner#7145

Merged
samsonasik merged 1 commit intorectorphp:mainfrom
calebdw:calebdw/push-pvuvlzkyuuzt
Aug 13, 2025
Merged

fix: allow more nodes to be passed to AttributeGroupNewLiner#7145
samsonasik merged 1 commit intorectorphp:mainfrom
calebdw:calebdw/push-pvuvlzkyuuzt

Conversation

@calebdw
Copy link
Contributor

@calebdw calebdw commented Aug 13, 2025

Hello!

I need to pass a ClassMethod to this class, but it didn't accept it.

There's about 11 classes that have the attrGroups property:

image

Rather than add them all I just decided to allow all Node and return early if the property doesn't exist or is empty

Thanks!

@samsonasik
Copy link
Member

We only use on existing usage on rector internal, not reuse. Do you have rule that use other node than defined in existing param type?

@calebdw
Copy link
Contributor Author

calebdw commented Aug 13, 2025

@samsonasik samsonasik merged commit 3882cb5 into rectorphp:main Aug 13, 2025
49 checks passed
@samsonasik
Copy link
Member

Ok, Thank you @calebdw

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants