[php 8.3] Add json_validate rule by arshidkv12 · Pull Request #7200 · rectorphp/rector-src

arshidkv12 · 2025-08-30T05:12:49Z

arshidkv12 · 2025-08-30T05:36:28Z

vendor/bin/phpstan analyse --ansi                                                                             ✔   
Note: Using configuration file /Users/arshid/Downloads/rector-src/phpstan.neon.

In Resolver.php line 482:
                                                                                                                                                                  
  Service 'rules.0' (type of Symplify\PHPStanRules\Rules\NoDynamicNameRule): Service of type Symplify\PHPStanRules\TypeAnalyzer\CallableTypeAnalyzer required by  
   $callableTypeAnalyzer in NoDynamicNameRule::__construct() not found. Did you add it to configuration file?

src/ValueObject/PhpVersionFeature.php

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

src/ValueObject/PhpVersionFeature.php

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/config/configured_rule.php

arshidkv12 · 2025-08-30T10:58:23Z

Changed the value from 80 to 83

samsonasik · 2025-08-30T11:02:25Z

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate.php.inc

@@ -0,0 +1,15 @@
+<?php


use lower character on fixture if possible for fixture filnames:

-Json_validate.php.inc +json_validate.php.inc

it seems still use upper case fixfture file name, please use lower case

github diff seems still show old name, is this file not removed?

samsonasik · 2025-08-30T11:03:20Z

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate_named.php.inc

+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE){


this fixture content seems equal with other fixture, seems copy paste content.

I changed it.

samsonasik · 2025-08-30T11:07:12Z

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

+            [
+                new CodeSample(
+                    <<<'CODE_SAMPLE'
+if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE) {


json_decode() allow pass depth and flag argument, and from index 1 to 3, they are optional so isset on function arguments per index target is needed.

samsonasik · 2025-08-30T11:11:37Z

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate_named.php.inc

+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_decode(json: $json, true) !== null && json_last_error() === JSON_ERROR_NONE){


if this goes to be check, add flipped named argument position fixture as well.

Let me check.

…absSetList" usage (rectorphp#7204) * Remove removed "Rector\Symfony\Set\FOSRestSetList" usage * SetList more removal

staabm · 2025-09-01T13:03:02Z

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/Json_validate_reverse.php.inc

+<?php
+namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
+
+if (json_last_error() === JSON_ERROR_NONE && json_decode(associative: true, json: $json) !== null){


Checking for a previous json_* calls error should not transform the code.

I changed 1259088

samsonasik

The depth and flag value need to check, if not match, just skip as that means possibly different purpose, see polyfill code

https://github.com/symfony/polyfill-php83/blob/17f6f9a6b1735c0f163024d959f700cfbc5155e5/Php83.php#L26-L36

samsonasik · 2025-09-03T09:57:43Z

src/ValueObject/PhpVersionFeature.php

    public const DYNAMIC_CLASS_CONST_FETCH = PhpVersion::PHP_83;
+
+    /**
+     * @var int


add @see to wiki for it.

@see https://wiki.php.net/rfc/json_validate

arshidkv12 · 2025-09-03T10:09:24Z

The depth and flag value need to check, if not match, just skip as that means possibly different purpose, see polyfill code

https://github.com/symfony/polyfill-php83/blob/17f6f9a6b1735c0f163024d959f700cfbc5155e5/Php83.php#L26-L36

Let me check it.

samsonasik · 2025-09-03T10:12:35Z

Ref for downgrade rule that ready as well:

[DowngradePhp83] Add DowngradeJsonValidateRector rector-downgrade-php#313

samsonasik · 2025-09-03T16:09:22Z

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

+    {
+        foreach ($positions as $position) {
+            $arg = $args[$position] ?? '';
+            if ($arg instanceof Arg && $arg->name instanceof Identifier && $arg->name->toString() === 'flags') {


Actually, you can get arg by name or position via getArg($name, $position)

https://github.com/nikic/PHP-Parser/blob/f7c23a43eee861070ab4e88819a4e76a611c7e4f/lib/PhpParser/Node/Expr/CallLike.php#L36-L59

samsonasik · 2025-09-03T17:02:05Z

phpunit.xml

    colors="true"
    executionOrder="defects"
    defaultTestSuite="main"
+             stopOnError="true"


why? please create separate PR for unrelated change

samsonasik · 2025-09-03T17:03:02Z

...ality/Rector/Class_/InlineConstructorDefaultToPropertyRector/Fixture/skip_complex_assign.php

@@ -0,0 +1,13 @@
+<?php


this .php fixture file seems commited during cut in the middle run unit test, please revert

samsonasik · 2025-09-03T17:04:20Z

rules/Php85/Rector/FuncCall/ChrArgModuloRector.php

        return PhpVersionFeature::DEPRECATE_OUTSIDE_INTERVEL_VAL_IN_CHR_FUNCTION;
    }
-}
+}


unrelated change, please revert

samsonasik · 2025-09-03T17:04:25Z

src/Configuration/RectorConfigBuilder.php

        return $this;
    }
-}
+}


unrelated change, please revert

arshidkv12 · 2025-09-03T17:57:57Z

#7213 Apologies for the mistake, corrected now

github-actions · 2026-02-01T03:57:52Z

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

Arshid added 7 commits August 30, 2025 10:39

[php 8.3] Add json_validate rule

f99fbbd

[php 8.3] Add json_validate rule

bfd6894

[php 8.3] Add json_validate rule

ebb70d1

[php 8.3] Add json_validate rule

634fb9d

[php 8.3] Add json_validate rule

c640e56

[php 8.3] Add json_validate rule

d73f7bb

[php 8.3] Add json_validate rule

57ff8c0

Arshid added 4 commits August 30, 2025 11:09

[php 8.3] Add json_validate rule

4d2be54

[php 8.3] Add json_validate rule

5763420

[php 8.3] Add json_validate rule

70794c6

[php 8.3] Add json_validate rule

e62a32c

samsonasik reviewed Aug 30, 2025

View reviewed changes

src/ValueObject/PhpVersionFeature.php Outdated Show resolved Hide resolved

Arshid added 2 commits August 30, 2025 12:46

[php 8.3] Add json_validate rule

996ff1a

[php 8.3] Add json_validate rule

ebc2672

samsonasik reviewed Aug 30, 2025

View reviewed changes

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php Outdated Show resolved Hide resolved

[php 8.3] Add json_validate rule

cd85f76

samsonasik reviewed Aug 30, 2025

View reviewed changes

src/ValueObject/PhpVersionFeature.php Outdated Show resolved Hide resolved

samsonasik reviewed Aug 30, 2025

View reviewed changes

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php Outdated Show resolved Hide resolved

samsonasik reviewed Aug 30, 2025

View reviewed changes

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/config/configured_rule.php Outdated Show resolved Hide resolved

Arshid added 3 commits August 30, 2025 16:23

[php 8.3] Add json_validate rule

6c975d8

[php 8.3] Add json_validate rule

e23d2c7

[php 8.3] Add json_validate rule

3377025

TomasVotruba requested a review from samsonasik August 30, 2025 11:00

samsonasik reviewed Aug 30, 2025

View reviewed changes

[php 8.3] Add json_validate rule

be1813a

samsonasik reviewed Aug 30, 2025

View reviewed changes

samsonasik and others added 2 commits September 1, 2025 17:09

Remove removed "Rector\Symfony\Set\FOSRestSetList/JMSSetList/Sensiol…

0424066

…absSetList" usage (rectorphp#7204) * Remove removed "Rector\Symfony\Set\FOSRestSetList" usage * SetList more removal

[php 8.3] Add json_validate rule

5dcdd8f

staabm reviewed Sep 1, 2025

View reviewed changes

Arshid and others added 5 commits September 1, 2025 19:13

[php 8.3] Add json_validate rule

1259088

Merge branch 'main' into json_validate

e4412d6

[php 8.3] Add json_validate rule

2ef3815

[php 8.3] Add json_validate rule

c5a036e

[php 8.3] Add json_validate rule

216124c

samsonasik requested changes Sep 3, 2025

View reviewed changes

samsonasik reviewed Sep 3, 2025

View reviewed changes

[php 8.3] Add json_validate rule

04e2ac3

Arshid added 3 commits September 3, 2025 16:25

[php 8.3] Add json_validate rule

bfc6cc1

[php 8.3] Add json_validate rule

f9ad159

[php 8.3] Add json_validate rule

77c8a6e

samsonasik reviewed Sep 3, 2025

View reviewed changes

Arshid added 2 commits September 3, 2025 22:20

[php 8.3] Add json_validate rule

22de000

[php 8.3] Add json_validate rule

d55c5c4

samsonasik reviewed Sep 3, 2025

View reviewed changes

src/Configuration/RectorConfigBuilder.php

return $this;

}

}

} No newline at end of file

Copy link

Member

samsonasik Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change, please revert

arshidkv12 and others added 3 commits September 3, 2025 22:50

Merge branch 'rectorphp:main' into json_validate

6df1782

[php 8.3] Add json_validate rule

5340f45

[php 8.3] Add json_validate rule

a6f77c0

arshidkv12 closed this Sep 3, 2025

github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2026

Uh oh!

Conversation

arshidkv12 commented Aug 30, 2025

Uh oh!

arshidkv12 commented Aug 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arshidkv12 commented Aug 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samsonasik left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arshidkv12 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samsonasik commented Sep 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arshidkv12 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

samsonasik left a comment •

edited

Loading

arshidkv12 commented Sep 3, 2025 •

edited

Loading

arshidkv12 commented Sep 3, 2025 •

edited

Loading