Improve assert rule #7207
Merged
Improve assert rule #7207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-more-types
branch
from
d37e687 to
3aabf58
Compare
staabm
reviewed
Sep 1, 2025
|
|
||
| private function matchTypeToAssertMethod(Type $type): ?string | ||
| { | ||
| if ($type instanceof IntegerType) { |
Contributor
There was a problem hiding this comment.
Should use $type->isInteger()->yes() so it works also with integer ranges ?
Member
Author
There was a problem hiding this comment.
I want to start with basic "strict" types first, test it in the wild and then we can iterate further.
rules/Assert/Rector/ClassMethod/AddAssertArrayFromClassMethodDocblockRector.php
Show resolved
Hide resolved
Member
|
@TomasVotruba I think we need to have service like:
|
Member
Author
|
Agreed, this needs an improvement If this rule is enabled, it should throw error instead if package is missing. |
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
* add ASSERT set list * add fixture to cover float and bool types
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7206