[AutoImport] Do not rename different namespaced function on auto import + RenameFunctionRector #7214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Per note at rectorphp/rector#9349 (comment) , it can properly skipped if function is properly loaded https://getrector.com/demo/785dfa4f-769d-4d5a-b9b1-c33392368277 |
samsonasik
changed the title
Member
Author
|
Fixed 🎉 /cc @wannevancamp , it just imported to use statement, but not renamed, since namespaced function is different 👍 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
|
👍 |
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
…uto import + RenameFunctionRector (rectorphp#7214)" This reverts commit 084fd1f.
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
…rt + RenameFunctionRector (rectorphp#7214) * [AutoImport] Skip different namespaced function on auto import + RenameFunctionRector * update fixture * Fix
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
…uto import + RenameFunctionRector (rectorphp#7214)" This reverts commit 084fd1f.
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
…rt + RenameFunctionRector (rectorphp#7214) * [AutoImport] Skip different namespaced function on auto import + RenameFunctionRector * update fixture * Fix
arshidkv12
pushed a commit
to arshidkv12/rector-src
that referenced
this pull request
Sep 4, 2025
…rt + RenameFunctionRector (rectorphp#7214) * [AutoImport] Skip different namespaced function on auto import + RenameFunctionRector * update fixture * Fix
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9349
Ref https://getrector.com/demo/faea2b6a-edbc-4265-a034-bff79354815d