-
-
Notifications
You must be signed in to change notification settings - Fork 432
Replace with http_get_last_response_headers() call #7227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is invalid, the variable is undefined by default, and we don't know if it is a global variable or not, eg via include. Manual verify is the way if needed. |
|
Ok. |
|
No, rector can't handle variable - global use. It always depends on usage of the project. |
|
I am saying this is not related to this PR. Please add the details of the new implementations required, and then I can work on them |
|
There is no implementation can be handled by rector for this, not sure if you mean on php-src itself, then I have no idea about that. |
|
Thank you. I’m ready to contribute. Could you please suggest some ideas, similar to this: rectorphp/rector#9265 |
|
Some new feature that introduce new syntax, eg: public function __construct(
- final public string $id
+ /** @final */
+ public string $id
) {}see https://3v4l.org/3XL5r/rfc#vgit.master Some consideration that see https://3v4l.org/noq7hD/rfc#vgit.master which works on other flag, eg: see https://3v4l.org/Bo7Fr/rfc#vgit.master The downgrade rule can be created and registered at |
|
Thank you |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_http_response_header_predefined_variable