Manual install ocramius/package-versions on build downgrade to test php 8.5#7434
Manual install ocramius/package-versions on build downgrade to test php 8.5#7434TomasVotruba merged 5 commits intomainfrom
Conversation
|
@TomasVotruba I think we can give it a try. This is needed so we can make downgrade rule for pipe operator which the syntax error on php < 8.5 so we may can use: #[RequiresPhp('>= 8.5')]on PHPUnit test there. |
| # avoid phpstan/phpstan dependency duplicate | ||
| note "Remove PHPStan to avoid duplicating it" | ||
|
|
||
| composer require ocramius/package-versions --working-dir "$BUILD_DIRECTORY" |
There was a problem hiding this comment.
Can you add reasoning "why" we need to do this? + A note to remove this, once PHP 8.5 is allowed there: Ocramius/PackageVersions#270
I was bit confused to see package moved here :)
There was a problem hiding this comment.
Btw, do we really need this package? There is vendor/installed.json we might use
There was a problem hiding this comment.
I think the package is reliable to verify/get package version with version + hash, using custom code may need another research how this tackle various usage of versions definition
4a7a476 to
c451f2e
Compare
|
Looks good 👍 |
|
Downgrade build seems error, https://github.com/rectorphp/rector-src/actions/runs/18425355698/job/52505769692#step:11:75 will check if related with it and is resolvable |
|
Resolved downgrade build at PR: |
Per PR:
This PR apply manual install
ocramius/package-versionson build downgrade.Closes #7237