Add parameter to withPreparedSets() to include all SetList#7458
Closed
Tamas-hi wants to merge 2 commits intorectorphp:mainfrom
Closed
Add parameter to withPreparedSets() to include all SetList#7458Tamas-hi wants to merge 2 commits intorectorphp:mainfrom
Tamas-hi wants to merge 2 commits intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Oct 10, 2025
Merge all with existings sets Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
approved these changes
Oct 11, 2025
Member
|
I'm having second thoughts about this. Once a few couple months, we add a new set. Just last month we added docblock types, its first version: https://getrector.com/blog/rector-22-new-rules-for-array-docblocks If this set is enabled magically without anybody knowing, it would cause lot of unwanted changes. The "all" option would turn into "list all but that new set". It could be similar to "run all available coding standard sets on this code". Some of them might be conflicting, in a loop or mutually exclusive. Thanks for the work though 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an "all" parameter to the withPreparedSets() function to offer the possibility for including all SetList.
Closes rectorphp/rector#9417