[type-declaration] Add AddParamStringTypeFromSprintfUseRector#7477
Merged
TomasVotruba merged 3 commits intomainfrom Oct 11, 2025
Merged
[type-declaration] Add AddParamStringTypeFromSprintfUseRector#7477TomasVotruba merged 3 commits intomainfrom
TomasVotruba merged 3 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-param-string-type-based-on-sprtinf
branch
from
2bdda81 to
19e03ac
Compare
samsonasik
reviewed
Oct 11, 2025
| return null; | ||
| } | ||
|
|
||
| $hasChanged = false; |
Member
There was a problem hiding this comment.
check parent method exists guard is needed here
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another cherry pick from one private project. We kept filling
stringtype where value was always used in thesprintf()call.It might have couple edge cases (like stringable objetcs), so I put this rule in the of level.
class SomeClass { - public function formatMessage($name) + public function formatMessage(string $name) { return sprintf('My name is %s', $name); } }