[PHP 8.5] Replace WrapFuncCallWithPhpVersionIdCheckerRector with RemoveFuncCallRector removal#7520
Merged
TomasVotruba merged 1 commit intomainfrom Oct 20, 2025
Merged
Conversation
1da50fd to
750f972
Compare
Member
|
For note: by this, on downgrade php 8.5 rule, we need downgrade rule to verify add back removed code, then it should add the removed code listed, for example: $s = curl_exec($curl) ?: $s;
+if (PHP_VERSION_ID < 80500) {
+. curl_close($curl);
+}
echo "other code unrelated to curl here, above must be closed first with wrap";because there is no replacement function in php 8.4 and below, and needed. |
…veFuncCallRector removal
750f972 to
8a6c93a
Compare
Member
Author
|
@samsonasik Let's ignore this one, as most likely these functions are not downgraded in the first place. Also, the RFC (https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_no-op_functions_from_the_resource_to_object_conversion) states it's been without behavior since PHP 8.0/PHP 8.1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects #7128
These functions have no effect on PHP 8.5 (all of them since PHP 8.0/8.1), and can be removed.
Comment with more context: #7128 (comment)
Removing original wrapping rule, as it add unrelated logic to the upgrade path.