[dead-code] Add RemoveNextSameValueConditionRector#7525
Merged
TomasVotruba merged 3 commits intomainfrom Nov 27, 2025
Merged
Conversation
3aa2d76 to
e4e5268
Compare
samsonasik
requested changes
Oct 22, 2025
Member
samsonasik
left a comment
There was a problem hiding this comment.
This need skip for re-assign variable if compared in condition, see
staabm
reviewed
Oct 22, 2025
e4e5268 to
19a6ef1
Compare
Member
Author
|
@samsonasik I've just rebased the PR in latest |
Member
|
I will try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are 2 conditions following each other, they have the same condition, without side effect, the first condition is already evaluated. The 2nd one can be removed:
public function __construct(array $items) { $count = 100; if ($items === []) { $count = 0; - } - if ($items === []) { return $count; } }Spotted in b52ae95