[code-quality] Add ReplaceConstantBooleanNotRector#7527
Merged
TomasVotruba merged 2 commits intorectorphp:mainfrom Oct 21, 2025
Merged
[code-quality] Add ReplaceConstantBooleanNotRector#7527TomasVotruba merged 2 commits intorectorphp:mainfrom
TomasVotruba merged 2 commits intorectorphp:mainfrom
Conversation
john-shaffer
force-pushed
the
add-replace-constant-boolean-not-rector
branch
from
8b16ecf to
15ed1fb
Compare
john-shaffer
force-pushed
the
add-replace-constant-boolean-not-rector
branch
from
15ed1fb to
8c97f9f
Compare
samsonasik
reviewed
Oct 21, 2025
rules/CodeQuality/Rector/BooleanNot/ReplaceConstantBooleanNotRector.php
Outdated
Show resolved
Hide resolved
Member
|
Looks good, thank you for new rule 👍 |
john-shaffer
added a commit
to staticweb-io/static-deploy
that referenced
this pull request
Oct 23, 2025
This was merged in to rector core with rectorphp/rector-src#7527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negated constant boolean can be trivially changed to the other constant boolean.
class IfCondition { public function run() { - if (!true) { + if (false) { return true; } return false; } }I am using this in tandem with bootstrapped constants. It allows dead code elimination rectors to remove blocks of code when the appropriate constants are defined.