[Php81] Keep nullable param on NewInInitializerRector

[samsonasik]

@TomasVotruba per our discussion on 153fc78#r168615132

since the rule register back to php81 set, this safe belt keep nullable is needed.

this to avoid new issue opened again:

• Incorrect behavior of NewInInitializerRector rector#8971

This needs to be nullable, or it will not safe, however, the drawback is property itself become nullable, while it originally not, as it always initialized inside constructor before.

This also ensure no bc break

[samsonasik]

Ready to merge 👍

[TomasVotruba]

Thank you. I'm wondering how this rule could be ever useful. I personally never saw it practice, except nested PHP attributes :)

Let's give this another round and collect feedback in real projects. The nullable property might be good enough to use the feature in codebase 👍

[samsonasik]

@TomasVotruba you can see example on spiral framework that it cause bc break

https://github.com/spiral/framework/blob/3d1055a956093bc7a72e531cf55fb5c3e410ab29/rector.php#L96

so skip there, make nullable is the way it has less bc break.

[TomasVotruba]

We need exact code structure.

[samsonasik]

@TomasVotruba see exact example commit

spiral/framework@9cf5a48

that reverted previous apply and skip the new in initializers, because nullable removed