[CodingStyle] Skip Method target not found or defined only via @method on FunctionLikeToFirstClassCallableRector#7553
Merged
samsonasik merged 3 commits intomainfrom Oct 24, 2025
Merged
Conversation
…on FunctionLikeToFirstClassCallableRector
…on FunctionLikeToFirstClassCallableRector
samsonasik
force-pushed
the
skip-method-not-exists
branch
from
f3d0f85 to
edbb34f
Compare
Member
Author
|
Fixed 🎉 /cc @zishang520 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
| // exists, but by @method annotation | ||
| if ($reflection instanceof AnnotationMethodReflection) { | ||
| return true; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9460
When target method not found or found but only via
@method, it can be magic based method, and not safe, so this PR skip it.