Narrow object return type v2#7586
Closed
Orest-Divintari wants to merge 13 commits intorectorphp:mainfrom
Closed
Conversation
When the actual return type of a method is a subtype of the declared return type, we can replace the declared return type with the actual return type
Member
|
Let's mark this draft so wait for PR: |
Member
|
@Orest-Divintari please rebase for the improvement on override parent method. |
Contributor
Author
|
@samsonasik created a new pr because it was easier than resolving conflicts you can find it here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to this pr , this PR extends the rule to narrow return types from any supertype (interfaces, abstract classes, and parent classes) to the actual concrete class being returned.
Before this change:
objecttype or no parent method existedAfter this change: