[cleanup] Make FirstClassCallableRector use attributes over node traverser hacks#7696
Merged
TomasVotruba merged 2 commits intomainfrom Dec 1, 2025
Merged
[cleanup] Make FirstClassCallableRector use attributes over node traverser hacks#7696TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
samsonasik
reviewed
Dec 1, 2025
src/NodeTypeResolver/PHPStan/Scope/NodeVisitor/PropertyOrClassConstDefaultNodeVisitor.php
Outdated
Show resolved
Hide resolved
b93e507 to
dd7c4bf
Compare
Member
|
I am not sure about this, this may cause issue on performance, since it adds new "preload" attribute whether used or not, and people tend to use big data on property/constant. The previous implementation will only set below node on specific rule, now this set attribute on any rule. |
Member
Author
|
I'll give it a test run for performance, but I think we'll be safe. |
Member
Author
|
Seems no diff at all. Mind the before 387.88s user 7.07s system 1778% cpu 22.207 total
351.04s user 6.39s system 1735% cpu 20.598 totalafter 376.07s user 6.51s system 1716% cpu 22.291 total
361.87s user 6.76s system 1697% cpu 21.714 total
343.33s user 6.33s system 1644% cpu 21.268 total |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.