Merged
Conversation
TomasVotruba
force-pushed
the
tv-version-check-attribute
branch
from
cf0a8a9 to
f7bcc84
Compare
staabm
reviewed
Dec 3, 2025
| use Rector\NodeTypeResolver\Node\AttributeKey; | ||
| use Rector\PhpParser\NodeTraverser\SimpleNodeTraverser; | ||
|
|
||
| final class PhpVersionConditionNodeVisitor extends NodeVisitorAbstract implements DecoratingNodeVisitorInterface |
Contributor
There was a problem hiding this comment.
instead of this, you might be interessted in $scope->getPhpVersion() which returns a version which can be narrowed by composer.json constraints and/or if(PHP_VERSION_ID > xy) check etc.
see also https://staabm.github.io/2024/11/14/phpstan-php-version-narrowing.html
Member
Author
There was a problem hiding this comment.
I'll give it a go today, thanks for heads-up 👌
Member
Author
There was a problem hiding this comment.
Just tested on the downgrade rule I've introduced this for: https://github.com/rectorphp/rector-downgrade-php/pull/349/files#diff-5f67d22ffde95a027219085ed3266b9ae5277dd85eecf7771c41881372cba9af
And it picks up local version (PHP 8.2), so it never downgrades to PHP 8.1. Not suitable for this kind of operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.