Skip to content
/ rector-src Public

Fix json validate rule #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Jan 29, 2026
Merged

Fix json validate rule #7865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85a9220
Merge remote-tracking branch 'upstream/main'
carlos-granados Jan 29, 2026
880a54c
Fix JsonValidateRector: remove associative argument not supported by …
carlos-granados Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/elseif.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if ($flag) {
echo "skip";
} elseif (json_validate($config, true)) {
} elseif (json_validate($config)) {
echo "valid config";
}
}
2 changes: 1 addition & 1 deletion rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/inline_string.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ if (json_decode('{"a":1}', true) !== null && json_last_error() === JSON_ERROR_NO
<?php
namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate('{"a":1}', true)) {
if (json_validate('{"a":1}')) {
echo "inline";
}
2 changes: 1 addition & 1 deletion rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_flag.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if (json_decode($json, true, 3) !== null && json_last_error() === JSON_ERROR_NON

namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate($json, true, 3)){
if (json_validate($json, 3)){
echo 1;
}
?>
2 changes: 1 addition & 1 deletion rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_validate.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if (json_decode($json, true) !== null && json_last_error() === JSON_ERROR_NONE){

namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate($json, true)){
if (json_validate($json)){
echo 1;
}
?>
2 changes: 1 addition & 1 deletion rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_validate_base.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ if (json_decode($json, true, 512) !== null && json_last_error() === JSON_ERROR_N

namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate($json, true, 512)){
if (json_validate($json, 512)){
echo 1;
}
?>
4 changes: 2 additions & 2 deletions rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_validate_named.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (json_decode(associative: true, json: $json) !== null && json_last_error() ==
<?php
namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate(associative: true, json: $json)){
if (json_validate(json: $json)){
echo 1;
}
?>
?>
4 changes: 2 additions & 2 deletions ...tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_validate_named_base.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ if (json_decode(json: $json, associative: true) !== null && json_last_error() ==
<?php
namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;

if (json_validate(json: $json, associative: true)){
if (json_validate(json: $json)){
echo 1;
}
?>
?>
12 changes: 11 additions & 1 deletion rules/Php83/Rector/BooleanAnd/JsonValidateRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,18 @@ public function refactor(Node $node): ?Node
return null;
}

// Remove associative argument (position 1 or named) - json_validate does not have this param
foreach ($args as $index => $arg) {
if ($arg instanceof Arg && (
($arg->name !== null && $arg->name->toString() === 'associative') ||
($arg->name === null && $index === 1)
)) {
unset($funcCall->args[$index]);
break;
}
}

$funcCall->name = new Name('json_validate');
$funcCall->args = $args;

return $funcCall;
}
Expand Down