chore: bulk-import: update dependency prettier to v3.7.4 #1942
Conversation
kim-tsao
requested review from
a team,
debsmita1,
its-mitesh-kumar and
rm3l
as code owners
Changed Packages
|
kim-tsao
force-pushed
the
fix_prettier_bulk_import
branch
2 times, most recently
from
4b35750 to
c758bf6
Compare
kim-tsao
force-pushed
the
fix_prettier_bulk_import
branch
from
c758bf6 to
6ef0658
Compare
|
Had to update prettier in the root yarn.lock, otherwise I could not commit the changed files |
| source /** | ||
| * Import Source: | ||
| * * 'config' - Import from static catalog location configuration in 'app-config' | ||
| * * 'location' - Import of user registered entities using locations endpoint | ||
| * * 'integration' - Import using a GitHub integration | ||
| * * null - Import source is unknown | ||
| * | ||
| */ | ||
| Source; | ||
| */?: Source; |
There was a problem hiding this comment.
This change looks wired. Can you maybe exclude generated from prettier in the bulk import and run the generate api step again?
There was a problem hiding this comment.
It looks like it's already excluded here but maybe it needs to be added at the workspace level
There was a problem hiding this comment.
I re-generated the api using this command yarn workspace @red-hat-developer-hub/backstage-plugin-bulk-import-backend run openapi but it resulted in a number of changes. LMK if this is expected
kim-tsao
force-pushed
the
fix_prettier_bulk_import
branch
from
6ef0658 to
9f1acad
Compare
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
kim-tsao
force-pushed
the
fix_prettier_bulk_import
branch
from
100d683 to
dd158b9
Compare
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
2 participants
Hey, I just made a Pull Request!
Fixes the bulk-import prettier errors in this Renovate PR
✔️ Checklist