fix(orchestrator): resolve TypeScript compilation errors #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polasudo
requested review from
batzionb,
gciavarrini and
mareklibra
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Fixes RHIDP-11204
This PR fixes TypeScript compilation errors in the orchestrator plugins:
1. Fix incorrect import paths:
- Change '@backstage/types/index' to '@backstage/types' in 7 files
2. Add missing type declarations:
- Add '@types/js-yaml' to devDependencies in orchestrator-common
- Add '@types/js-yaml' to devDependencies in scaffolder-backend-module-orchestrator
3. Add missing devDependencies for frontend plugin:
- Add 'react', 'react-dom', 'react-router-dom' to orchestrator devDependencies
(required for dynamic plugin export to resolve peer dependencies)
Files modified:
- plugins/orchestrator-common/package.json
- plugins/orchestrator/package.json
- plugins/scaffolder-backend-module-orchestrator/package.json
- plugins/orchestrator-form-react/src/components/AuthRequester.tsx
- plugins/orchestrator-form-widgets/src/uiPropTypes.ts
- plugins/orchestrator-form-widgets/src/utils/evaluateTemplate.test.ts
- plugins/orchestrator-form-widgets/src/utils/useFetch.ts
- plugins/orchestrator-form-widgets/src/utils/useFetchAndEvaluate.ts
- plugins/orchestrator/src/utils/deepSearchObject.ts
- plugins/scaffolder-backend-module-orchestrator/src/actions/getWorkflowParams.ts
polasudo
force-pushed
the
fix/orchestrator-tsc-errors-RHIDP-11204
branch
from
63405dc to
f394152
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RHIDP-11204
This PR fixes TypeScript compilation errors in the orchestrator plugins:
Fix incorrect import paths:
Add missing type declarations:
Add missing devDependencies for frontend plugin:
Hey, I just made a Pull Request!
✔️ Checklist