RI-7779: remove duplicate tooltip in tag input field #5313
Merged
+39
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix duplicate tooltip issue in the database tags modal. When hovering over an invalid tag key field, two tooltips were appearing simultaneously with misaligned text colors.
Changes:
RiTooltipwrapper fromTagInputFieldcomponentTextInput's built-in error tooltip for consistent stylingTagInputFieldPropstype to dedicatedTagInputField.types.tsfile per linting rulesScreen.Recording.2025-12-05.at.15.02.10.mov
Screen.Recording.2025-12-05.at.15.32.05.mov
Testing
Closes #RI-7779
Note
Removes redundant tooltip wrapper in
TagInputFieldto prevent duplicate tooltips, extracts its props toTagInputField.types.ts, and tidiesTagSuggestionslogic.TagInputField: RemoveRiTooltipwrapper and rely onTextInput'serrorhandling; wrap input withspan.TagInputFieldPropstoredisinsight/ui/src/pages/home/components/database-manage-tags-modal/TagInputField.types.tsand import where used.TagSuggestions: Small refactor of suggestions computation (memoized filtering/mapping) without changing behavior.Written by Cursor Bugbot for commit 8384747. This will update automatically on new commits. Configure here.