Skip to content

remove remaining imports of typing_extensions #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotlambda wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −2
Open

remove remaining imports of typing_extensions #3873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
857a979
remove remaining imports of typing_extensions
dotlambda Dec 9, 2025
0102052
Merge branch 'master' into typing-extensions
petyaslavova Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion redis/multidb/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
from typing import List, Type, Union

import pybreaker
from typing_extensions import Optional

try:
from typing import Optional # Py 3.11+
Copy link
Collaborator

@petyaslavova petyaslavova Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly import it from typing and completely remove the typing_extensions import. The typing.Optional is available in our min supported version, which is 3.10

except ImportError:
from typing_extensions import Optional

from redis import ConnectionPool, Redis, RedisCluster
from redis.backoff import ExponentialWithJitterBackoff, NoBackoff
Expand Down
5 changes: 4 additions & 1 deletion redis/multidb/failure_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
from datetime import datetime, timedelta
from typing import List, Type

from typing_extensions import Optional
try:
from typing import Optional # Py 3.11+
except ImportError:
from typing_extensions import Optional

from redis.multidb.circuit import State as CBState

Expand Down