Improve README and start to decouple JSON #74
Conversation
| { | ||
| "element": "object", | ||
| "content": [ | ||
| { |
There was a problem hiding this comment.
To be honest, I think JSON may be the best way to express this structure as it is very detailed and contains a lot of information. I've left it in JSON, especially since the future paragraphs talk about "JSON" in comparison to this structure.
I have updated the serialisation of the meta components to follow JSON serialisation rules.
| } | ||
| ``` | ||
| - name: John Doe | ||
| - email: john@example.com |
There was a problem hiding this comment.
Perhaps it would make sense to keep this as JSON for consistency.
There was a problem hiding this comment.
Yeah, I think you're right. You could make the distinction that it's a JSON example.
There was a problem hiding this comment.
You may even link to the JSON serializarion rules.
smizell
left a comment
smizell
left a comment
There was a problem hiding this comment.
Looks good to me. I think keeping as JSON examples is a good idea and just add a note it's an example.
I approve but also know you want to change things so I'll pick request changes. That feels like an odd choice though :)
| } | ||
| ``` | ||
| - name: John Doe | ||
| - email: john@example.com |
There was a problem hiding this comment.
Yeah, I think you're right. You could make the distinction that it's a JSON example.
| } | ||
| ``` | ||
| - name: John Doe | ||
| - email: john@example.com |
There was a problem hiding this comment.
You may even link to the JSON serializarion rules.
| { | ||
| "element": "object", | ||
| "content": [ | ||
| { |
Starting #60.
NOTE: I've also added myself to Authors.