Adapt version migrator for recipe.yaml #2883
Conversation
Hofer-Julian
force-pushed
the
feat/version-migrator
branch
2 times, most recently
from
4540d89 to
9db0260
Compare
Write recipe.yaml not meta.yaml Add schema to recipe yaml Prepare test for the adapted migrator Adapt `update_build_number` for recipe.yaml fix: function signature to match baseclass Update version.py refactor: Improve `test_version_cupy` refactor: Improve "run_test_migration"
Hofer-Julian
force-pushed
the
feat/version-migrator
branch
from
9db0260 to
612b83c
Compare
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
I leave these comments, so I or even better @wolfv can more easily pick up this PR later on.
| A set of strings giving any errors found when updating the | ||
| version. The set will be empty if there were no errors. | ||
| """ | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
This still needs to be implemented.
update_version the meta.yaml pendant contains a lot of logic. One has to have a close look which parts of it are not necessary for recipe.yaml and how to adapt the rest that is.
| ) | ||
|
|
||
| # these are here for legacy migrators | ||
| pmy["version"] = pmy["meta_yaml"]["package"]["version"] |
There was a problem hiding this comment.
This function started out as a copy of run_test_migration the meta.yaml pendant. Only up to this point, I am fairly sure that nothing needs to be adapted anymore. The rest should be evaluated if it is needed or if it needs to be adapted.
| for case in cases: | ||
| replace_build_number(recipe, *case) | ||
|
|
||
| return yaml.dump(recipe, sort_keys=False) |
There was a problem hiding this comment.
yaml sorts the keys per default when deserializing. I don't think we ever want that, so let's remember to set the argument also for other cases of yaml.dump in this and other PRs.
|
Closing in favor of #2920 |
2 participants
No description provided.